Conversation
This pulls the zkverify patch to substrate-wasm-builder
Taken from zkVerify, same logics apply here
Now included in the docker image
Merged
ysibirski
reviewed
Jun 10, 2026
Comment on lines
+23
to
+24
| llvm: 'yes' | ||
| libclang-dev: 'yes' |
Contributor
There was a problem hiding this comment.
Please remove all the code related to these packages. They are part of base image we are using for building the project. It was also removed from zkverify repo
ysibirski
requested changes
Jun 10, 2026
* Remove pallet proxy * Format * Remove custom filter implementation * Rebase fixup * Revert changes leaked through rebase
ysibirski
reviewed
Jun 11, 2026
ysibirski
reviewed
Jun 11, 2026
ysibirski
reviewed
Jun 11, 2026
| FRONTIER_DB_VER_PATH="${PARA_CONF_BASE_PATH}/chains/${CHAIN_ID}/frontier/db/db_version" | ||
| if [ -e "${FRONTIER_DB_VER_PATH}" ]; then | ||
| FRONTIER_DB_VER=$(cat "${FRONTIER_DB_VER_PATH}") | ||
| if [ ${FRONTIER_DB_VER} == "2" ]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [ ${FRONTIER_DB_VER} == "2" ]; then | |
| if [ "${FRONTIER_DB_VER}" == "2" ]; then |
ysibirski
reviewed
Jun 11, 2026
| FRONTIER_DB_VER=$(cat "${FRONTIER_DB_VER_PATH}") | ||
| if [ ${FRONTIER_DB_VER} == "2" ]; then | ||
| log_green "INFO: old Frontier DB detected. Removing to allow correct reconstruction on the first run..." | ||
| rm -rf $(dirname "${FRONTIER_DB_VER_PATH}") |
Contributor
There was a problem hiding this comment.
Suggested change
| rm -rf $(dirname "${FRONTIER_DB_VER_PATH}") | |
| rm -rf "$(dirname "${FRONTIER_DB_VER_PATH}")" |
ysibirski
approved these changes
Jun 11, 2026
ysibirski
left a comment
ysibirski
left a comment
Contributor
There was a problem hiding this comment.
Look at two more entrypoint suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades VFlow to the Polkadot sdk 2512. Frontier and Moonbeam dependencies are updated accordingly.
We also add some Claude code skills to help perform specific tasks related to sdk upgrades.
TODO:
Cargo.tomlto point to the tagged release of zkVerify